Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #187

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Fix CI #187

merged 3 commits into from
Sep 19, 2024

Conversation

bmw
Copy link
Member

@bmw bmw commented Sep 17, 2024

I accidentally broke CI in #160. In that PR I tried to simplify our CI setup by just running tox which normally runs all standard tests, but I missed that TOXENV was set at the top of the file causing tox with no other arguments to only run mypy!

This PR fixes that, updates .pre-commit-config.yaml so it works with modern Pythons, and applies the minor changes from black.

@bmw bmw marked this pull request as ready for review September 17, 2024 23:49
@bmw bmw requested review from a team and wgreenberg and removed request for a team September 18, 2024 22:44
Copy link
Contributor

@wgreenberg wgreenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bmw bmw merged commit ed9901f into master Sep 19, 2024
14 checks passed
@bmw bmw deleted the fix-ci branch September 19, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants