FIX: Update to work with the rewritten API #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The small adjustments were needed to pass tests with the API rewritten to the FastAPI. In addition, missing debconf configuration was added.
|
@sebix @aaronkaplan Please take a look for testing FastAPI with the playbook |
sebix
reviewed
Feb 8, 2023
| @@ -5,4 +5,4 @@ | |||
| register: queuesnoauth | |||
| - name: Check if authentication works | |||
| assert: | |||
| that: "'{\"errors\": {\"Authentication Required\": \"Please provide valid Token verification credentials\"}}' in queuesnoauth.content" | |||
| that: "'{\"error\":{\"Authentication Required\":\"Please provide valid Token verification credentials\"}}' in queuesnoauth.content" | |||
There was a problem hiding this comment.
If the response changed, that indicates a breaking change.
There was a problem hiding this comment.
This is unfortunately true, but I didn't find any troubles with the IntelMQ Manager so far. But it needs to be verified one more time.
There are unfortunately some disadvantages of how hug works:
- the
errorskey in messages on auth error were set by hug; the rest of the API is usingerror(I assume the idea was to follow the same key, but it failed); - hug was returning the proper JSON response, but... without setting the proper content-type header. IntelMQ Manager handles well both versions.
There was a problem hiding this comment.
Thanks for checking all the details! I agree it's OK to go with the change then, but it should be mentioned in the CHANGELOG of intelmq-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The small adjustments were needed to pass tests
with the API rewritten to the FastAPI. In addition,
missing debconf configuration was added.