add gitea authn #296
Closed
add gitea authn #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
requested changes
Dec 28, 2020
|
|
||
| //func (gha *GiteaAuth) authUser(user string, password PasswordString) (err error, l Labels) { | ||
| func (gha *GiteaAuth) Authenticate(user string, password api.PasswordString) (bool, api.Labels, error) { | ||
| url := fmt.Sprintf("%s/v1/user/orgs", gha.getGiteaApiUri()) |
There was a problem hiding this comment.
You may wish to use the gitea go-sdk as it handles parsing of response, and many other helpers.
| if gha.config.GiteaApiUri != "" { | ||
| return gha.config.GiteaApiUri | ||
| } else { | ||
| return "https://git2.groschupp.org/api" |
There was a problem hiding this comment.
Default should be something such as https://gitea.com/api rather than a private install.
| @@ -22,7 +22,7 @@ generate: | |||
| github.com/cesanta/docker_auth/auth_server/server/... | |||
|
|
|||
| build: | |||
| CGO_ENABLED=0 go build -v --ldflags=--s | |||
| CGO_ENABLED=0 go build -v --ldflags=--s -pkgdir /tmp/go | |||
There was a problem hiding this comment.
This change is unrelated to this PR, could you raise another PR for this change and revert it here?
| if gha.config.GiteaWebUri != "" { | ||
| return gha.config.GiteaWebUri | ||
| } else { | ||
| return "https://git2.groschupp.org" |
|
@cgroschupp Hey, just checking if there is anything I can do to help out with this PR? I'm one of the project leads of Gitea and so I have some insight into that codebase. |
|
Gitea has a PR for supporting docker registry auth itself here: go-gitea/gitea#16048 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.