Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arrayvec to 0.5.1 #16

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Update arrayvec to 0.5.1 #16

merged 1 commit into from
Dec 23, 2021

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Jan 11, 2020

This will also cancel the dependency of nodrop, which is deprecated there

This will also cancel the dependency of `nodrop`, which is deprecated there
@cesarb
Copy link
Owner

cesarb commented Jan 12, 2020

Unfortunately, it also increases the minimum Rust release to 1.36; currently, this crate works on at least 1.20 (tested by travis-ci), and might even work on earlier releases. So this change can only be merged on the next incompatible release. Since the latest 0.4.x versions of arrayvec seem to have all the relevant fixes (through a build.rs which autodetects Rust 1.36 or later), and the only user of arrayvec is not part of this crate's API, I don't see any urgency.

@sylvestre
Copy link

@cesarb relying on very old crates make packaging for linux distro harder. arrayvec is used by other crates with the more recent version, blake2-rfc requires an old version which isn't compatible with the new version.

It forces us to either patch a crate, or to package two versions of arrayvec

@cesarb cesarb merged commit d4c14f2 into cesarb:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants