Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug reading in multiple seasons' events #48

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

specktakel
Copy link
Collaborator

Fixed bug where IC86_III and later would be read in if and only if IC86_II alone is queried with kwarg use_all==True

@specktakel specktakel requested a review from cescalara October 26, 2023 06:46
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2707db6) 55.29% compared to head (f3959e9) 55.33%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   55.29%   55.33%   +0.04%     
==========================================
  Files          24       24              
  Lines        4380     4384       +4     
==========================================
+ Hits         2422     2426       +4     
  Misses       1958     1958              
Files Coverage Δ
icecube_tools/detector/r2021.py 81.66% <100.00%> (ø)
icecube_tools/utils/data.py 71.91% <88.88%> (+0.19%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cescalara cescalara merged commit e47c509 into cescalara:master Oct 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants