Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix angular uncertainty #49

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Conversation

specktakel
Copy link
Collaborator

  • Removed the erroneous conversion of angular uncertainties from 50% to 1sigma.
  • Changed spatial likelihood to Rayleigh pdf on a sphere
  • Fixed some if-clause comparing an instance with a type
  • Formatting

@specktakel specktakel requested a review from cescalara February 7, 2024 15:55
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (f6295ec) 55.33% compared to head (e47e383) 55.33%.
Report is 1 commits behind head on master.

Files Patch % Lines
icecube_tools/detector/r2021.py 81.03% 11 Missing ⚠️
...ols/point_source_analysis/point_source_analysis.py 0.00% 2 Missing ⚠️
...ools/point_source_likelihood/spatial_likelihood.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   55.33%   55.33%           
=======================================
  Files          24       24           
  Lines        4384     4384           
=======================================
  Hits         2426     2426           
  Misses       1958     1958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@specktakel specktakel merged commit 35d7955 into cescalara:master Feb 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants