Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 22/23 Team #249

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Update 22/23 Team #249

merged 4 commits into from
Oct 21, 2022

Conversation

ruioliveira02
Copy link
Member

No description provided.

Copy link
Member

@miguelbrandao miguelbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@miguelbrandao miguelbrandao self-requested a review October 21, 2022 07:50
Copy link
Member

@miguelbrandao miguelbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass the team.json file through a prettier to fix the indentation issues (there are several)

"position": "Tesoureiro",
"image": "team/carlos-ferreira.jpg"
"image": "team/vitor-leite.jpg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vitor-lelis.jpg

}
},
{
"Carlos Ferreira": {
"Vitor Leite": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vitor Lelis?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

His last name is Leite. It is this way in the current site as well

public/team.json Outdated
}
},
{
"Rui Oliveira": {
"Tiago Pereira" : {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

public/team.json Outdated
},
{
"Enzo Vieira": {
"position": "Codiretor",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

"position": "Presidente",
"image": "team/miguel-brandao.jpg"
"image": "team/tiago-soares.jpg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing picture

miguelbrandao
miguelbrandao previously approved these changes Oct 21, 2022
Copy link
Member

@miguelbrandao miguelbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

public/team.json Outdated Show resolved Hide resolved
Co-authored-by: Nelson Estevão <nelsonmestevao@gmail.com>
@ruioliveira02 ruioliveira02 merged commit 64f8726 into main Oct 21, 2022
@ruioliveira02 ruioliveira02 deleted the ro/board-22-23 branch October 21, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants