Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve announcements pages #530
base: develop
Are you sure you want to change the base?
refactor: improve announcements pages #530
Changes from all commits
e9f3a43
750bedf
8f56c58
55b65af
f61df59
a010415
88d0b12
1c8defc
57d689d
3802137
0d17920
23558c6
f1800bc
6b0f7ec
678c82d
fac57ec
424175a
040ee69
5812fae
a7a468b
8735240
7f1935f
8f248e5
3d16dca
4384942
4a36fa3
a80c0fa
1af4b79
abe715e
01dfeb0
66bda3f
e8c16b7
458970f
8628165
799482b
0c07740
6fb1608
fc2552c
3907760
8f50450
df47eb3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two previous issues that still need to be fixed:
The button should disappear when viewing as a user or another organization.
View as a user and not organization:
View as other organization:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed, unless you are using a master account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, supposedly it is already working (let's not comment about the image used as an example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct in that sense.
However, when viewing as a master in user mode, the button appears—which may be fine—but attempting to edit raises this error:
The first strategy to address this should be fixing the error. If that's not possible, consider hiding the button.