This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
refactor: Staff Badge Component #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darguima
requested review from
joaodiaslobo,
ruioliveira02,
tiago-bacelar,
EnzoVieira,
ruilopesm and
MarioRodrigues10
✅ Deploy Preview for seium-stg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ruilopesm
reviewed
Dec 22, 2023
You can't list any badges as staff because the end time field for all badges has already passed the current date, changing the dates by hand on the database should fix the issue 🙏 |
|
@joaodiaslobo Oh, you are totally right. Forgot about that constraint 😅 |
tiago-bacelar
approved these changes
Jan 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the Badgedex on a previous PR, but now I noticed that also the "Give Badge" page from staff can use this component, so I adapted the Component to the staff and used it instead the repeated code.
The changes were that staff don't have badges so, we don't need highlight the owned ones, and that on the staff page we want a custom behavior instead that redirect to badge page.
Staff Page:
Attendee Page:
