Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.66 and add Cargo.lock #99

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

linrongbin16
Copy link

@linrongbin16 linrongbin16 commented Dec 13, 2024

This PR does several small things to improve the CI pipeline:

  1. Covers the "unicode_lines" feature in the unit tests of the CI pipeline.

  2. Bump MSRV to 1.66. Since in CI pipeline, the testing cargo +1.65 test will fail because the dependency "unicode-width=0.1.14" would fail the testing build. NOTE: the 1.65 can still successfully build the library, but it's failed build and run the tests.

    image

  3. Add "Cargo.lock" file into git repo because it is very useful to let people know exactly what dependencies this crate is using when build the library.

@linrongbin16 linrongbin16 changed the title Run more tests in CI pipeline Upgrade minimal required rustc version Dec 14, 2024
@linrongbin16 linrongbin16 marked this pull request as draft December 14, 2024 14:38
@linrongbin16 linrongbin16 changed the title Upgrade minimal required rustc version Upgrade required rustc to 1.66 and add Cargo.lock Dec 14, 2024
@linrongbin16 linrongbin16 marked this pull request as ready for review December 14, 2024 14:46
@linrongbin16 linrongbin16 changed the title Upgrade required rustc to 1.66 and add Cargo.lock Bump MSRV to 1.66 and add Cargo.lock Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant