This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Feature/mongodb #40
Merged
Feature/mongodb #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banzo
reviewed
Nov 3, 2021
values.yaml
Outdated
Comment on lines
459
to
460
| use mongodb | ||
| db.user.insert({name: "Ada Lovelace", age: 205}) |
There was a problem hiding this comment.
Those 2 commands would do a nice test, but should not be in the chart by default.
|
@SellamiRami can you add some justification in the PR description on why we chose the Bitnami chart over another (ex https://github.com/mongodb/helm-charts/tree/main/charts)? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding MongoDB to the Helm Chart of FADI.
The Bitnami Helm chart of MongoDB has been selected. Indeed, it is well ranked, maintained and documented in the ArtifactHub. Added to that, the open source community on GitHub is very active and helpful.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]