This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feature/en289 Add a one-volume option for persistence using subPath #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Dent <michael.dent@emrge.co.nz>
banzo
suggested changes
Jun 13, 2023
banzo
approved these changes
Jun 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the option of using one persistent volume instead of seven. Some platforms have limits on the number of PVs per node and this option would make it easier for Nifi to be scheduled on a node.
Which issue this PR fixes
Special notes for your reviewer:
I removed the existingClaim references in the README as the value no longer exists.
I noted that the default for persistence is still false, whereas the helm recommendations list says it should be enabled by default.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]