Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Add imagePullSecret to template #6

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Add imagePullSecret to template #6

merged 1 commit into from
Aug 7, 2019

Conversation

ebcFlagman
Copy link
Contributor

For use with custom nifi image and private repository

@alexnuttinck alexnuttinck self-requested a review August 7, 2019 09:05
@alexnuttinck alexnuttinck changed the base branch from master to develop August 7, 2019 13:11
@alexnuttinck alexnuttinck merged commit d05d997 into cetic:develop Aug 7, 2019
@alexnuttinck
Copy link
Contributor

Merged in 0.1.4. Thanks!

@ebcFlagman
Copy link
Contributor Author

I think I had a bug.
At the moment I've got the following error:

Error: release cl-nifi failed: StatefulSet in version "v1beta2" cannot be handled as a StatefulSet: v1beta2.StatefulSet.Spec: v1beta2.StatefulSetSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.InitContainers: []v1.Container: v1.Container.Command: []string: ReadString: expects " or n, but found {, error found in #10 byte of ...|rets:\n",{"name":"re|..., bigger context ...|keeper..."\n sleep 2\ndoneimagePullSecrets:\n",{"name":"regcred"}],"image":"busybox","name":"zooke|...

I think it must be {{- if .Values.image.pullSecret }} instead of {{- if .Values.image.pullSecret -}}
Can you verify this?

@alexnuttinck
Copy link
Contributor

@ebcFlagman should be fixed in 0.1.5.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants