This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
take statefulset pod annotations from Helm values #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Novakov <novakov.alex@gmail.com>
Signed-off-by: Alexey Novakov <novakov.alex@gmail.com>
Signed-off-by: Alexey Novakov <novakov.alex@gmail.com>
|
@alexnuttinck could you please code review this PR? |
alexnuttinck
approved these changes
Jul 27, 2020
|
Thanks @novakov-alexey, it will be present in the next release. |
|
Cool, thank you @alexnuttinck |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
User can setup Statefulset Pod template annotations. One of the use case is special Prometheus annotation to let it to scrape the NiFi metrics from the Statefulset Pods.
Which issue this PR fixes
Special notes for your reviewer:
@alexnuttinck
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]