This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Update Ingress to use networking.k8s.io/v1 (#21) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SellamiRami pinging as instructed in the template |
|
or @alexnuttinck ? |
remiDupuy
approved these changes
Jun 3, 2022
|
Hello @SellamiRami @alexnuttinck, when will it be merged ? Thanks ! |
pawelmuszynski
approved these changes
Feb 3, 2023
|
Is something blocking this PR? @SellamiRami @alexnuttinck @digiserg @FredM, can we merge it? |
|
I would also need this, also autoscaler is using deprecated api |
banzo
approved these changes
Feb 15, 2023
it should be ok in the latest chart version |
|
Thanks! Working nicely now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates the chart to use the a non-deprecated ingress api. I tried to do it in a backwards compatible way for cluster <1.19. I tested the change on my cluster with version 1.21.
Which issue this PR fixes
Special notes for your reviewer:
Checklist