Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Issue 65 #67

Merged
merged 6 commits into from
Jul 26, 2022
Merged

Issue 65 #67

merged 6 commits into from
Jul 26, 2022

Conversation

aeciopires
Copy link
Collaborator

@aeciopires aeciopires commented Jul 21, 2022

What this PR does / why we need it:

  • Bump chart and Zabbix version;
  • Added extraInitContainers and extraPodSpecs;
  • Improvements in documentation;

Example of config:

  extraPodSpecs:
    dnsPolicy: "None"
    dnsConfig:
      nameservers:
        - 1.2.3.4
      searches:
        - ns1.svc.cluster-domain.example
        - my.dns.search.suffix
      options:
        - name: ndots
          value: "2"
        - name: edns0
  extraInitContainers:
  - name: testing
    image: "busybox:latest"
    command: 
    - /bin/sh
    - -c
    - wget -O- https://zabbix.com
    resources: {}

Which issue this PR fixes

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@aeciopires
Copy link
Collaborator Author

Hi @maxenced!

Could you test these changes and see if it helps you?

Hi @sa-ChristianAnton!
What do you think of this implementation?

@david-moreau
Copy link

Hi @aeciopires,
Thanks for your works
I just test your change and it's works great 👍

@aeciopires
Copy link
Collaborator Author

Hello @david-moreau!

Thanks for your feedback. I will do merge.

@aeciopires
Copy link
Collaborator Author

Hello @tomsozolins!

Thanks for your contributition in PR #69.

I'm publishing a new version of the chart, I found it simpler to do git cherry-pick to merge your commit here than to have to publish another version just for that.

@aeciopires aeciopires merged commit c4fd444 into cetic:master Jul 26, 2022
@aeciopires aeciopires deleted the issue-65 branch July 26, 2022 10:22
Copy link
Contributor

@sa-ChristianAnton sa-ChristianAnton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's my review....

values.yaml Show resolved Hide resolved
templates/deployment-zabbix-server.yaml Show resolved Hide resolved
templates/deployment-zabbix-web.yaml Show resolved Hide resolved
templates/deployment-zabbix-webservice.yaml Show resolved Hide resolved
templates/statefulset-postgresql.yaml Show resolved Hide resolved
templates/statefulset-zabbix-proxy.yaml Show resolved Hide resolved
docs/example/kind/values.yaml Show resolved Hide resolved
Chart.yaml Show resolved Hide resolved
@aeciopires aeciopires mentioned this pull request Jul 26, 2022
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add extra parameter to add extra containers with sidecar pattern
4 participants