Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin future in RequestSender #39

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Pin future in RequestSender #39

merged 3 commits into from
Jul 3, 2023

Conversation

bemyak
Copy link
Contributor

@bemyak bemyak commented Mar 24, 2023

  • Bump deps
  • Remove deprecated feature

Fixes #38

@willstott101
Copy link
Contributor

Any particular reason to target 1.26 not 1.28 of Tokio in this? Perhaps it wasn't released

@bemyak
Copy link
Contributor Author

bemyak commented Jun 27, 2023

@willstott101, yes, 1.26 was the latest version when I submitted this PR, there is no reason not to bump it again.

@cetra3
Copy link
Owner

cetra3 commented Jun 27, 2023

Since this is a semver change can you bump the version number up?

@bemyak
Copy link
Contributor Author

bemyak commented Jun 28, 2023

@cetra3, it's a minor version bump, right? I don't think the public API has changed.

@bemyak
Copy link
Contributor Author

bemyak commented Jun 28, 2023

I've split this PR into separate commits and bumped the minor version

@cetra3
Copy link
Owner

cetra3 commented Jun 28, 2023

@bemyak the version of zmq has had a major revision in this PR, from 0.9 to 0.10, so I would consider this semver breaking. It's not that it's a big issue, just need to bump to 0.4.0

@willstott101
Copy link
Contributor

willstott101 commented Jun 28, 2023

zmq = ">=0.9.2" already pulled in 0.10 for us I think anyway, not sure a bump here would really reflect much in terms of stability, I guess it would cause a project which had a cargo lock from before 0.10 to now pull in 0.10 ... 🤷 you're probably right, worth bumping here too

@bemyak
Copy link
Contributor Author

bemyak commented Jun 28, 2023

OK, bumped it to 0.4.0

@cetra3
Copy link
Owner

cetra3 commented Jun 29, 2023

@bemyak For semver versions in rust < 1.0.0 i.e, 0.1 0.2 etc.. the minor version is treated as a major version & so something like >= 0.9.2 will only include 0.9.x versions

@bemyak
Copy link
Contributor Author

bemyak commented Jun 29, 2023

@cetra3, right. I've rewritten the commit message to remove the confusion.

Also >= is the default Cargo behavior:

The string "0.1.12" is a version requirement. Although it looks like a specific version of the time crate, it actually specifies a range of versions […]

Here are some more examples of version requirements […]

0.2.3  :=  >=0.2.3, <0.3.0

Is there anything else I can do here?

@cetra3 cetra3 merged commit d9703bf into cetra3:master Jul 3, 2023
@cetra3
Copy link
Owner

cetra3 commented Jul 3, 2023

Thanks! I've published this as 0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use RequestReplier in async task
3 participants