-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin future in RequestSender #39
Conversation
Any particular reason to target 1.26 not 1.28 of Tokio in this? Perhaps it wasn't released |
@willstott101, yes, |
Since this is a semver change can you bump the version number up? |
@cetra3, it's a minor version bump, right? I don't think the public API has changed. |
I've split this PR into separate commits and bumped the minor version |
@bemyak the version of |
|
OK, bumped it to |
@bemyak For semver versions in rust < |
@cetra3, right. I've rewritten the commit message to remove the confusion. Also
Is there anything else I can do here? |
Thanks! I've published this as |
Fixes #38