PR review additions/fixes

CHANGES.md

@@ -7,8 +7,11 @@
 - Open arcs are no longer modified for anchors, invalid border anchors will panic.
 - Grids now actually support border anchors.
 
-## Plot
-- Fixed annotation bounds calculation
+## Libs
+### Plot
+- The default style of plots changed
+- New style keys for enabling/disabling the shared zero tick for "school-book" style plots
+- New style keys for specifying the layer of different plot elements (`grid-layer`, `axis-layer`, `background-layer`)
 
 ## Misc
 - The `hide` function now support an additional `bounds:` parameter to enable canvas bounds adjustment for hidden elements

src/draw/grouping.typ

@@ -13,29 +13,6 @@
 
 #import "transformations.typ": move-to
 
-// Returns body if of type array, an
-// empty array if body is none or
-// the result of body called with ctx if of type
-// function. A function result of none will return
-// an empty array.
-#let resolve-body(ctx, body) = {
- assert(body == none or type(body) in (array, function),
- message: "Body must be of type array, function or none")
-
- let body = if type(body) == function {
- body(ctx)
- } else {
- body
- }
-
- return if body == none {
- ()
- } else {
- assert(type(body) == array)
- body
- }
-}
-
 /// Hides an element.
 ///
 /// Hidden elements are not drawn to the canvas, are ignored when calculating bounding boxes and discarded by `merge-path`. All
@@ -135,7 +112,7 @@
  message: "No such element '" + elem + "' in elements " + repr(ctx.nodes.keys()))
  named-drawables.push(ctx.nodes.at(elem).drawables)
  } else {
- for sub in resolve-body(ctx, elem) {
+ for sub in elem {
  let sub-drawables = ()
  (ctx: ctx, drawables: sub-drawables, ..) = process.element(ctx, sub)
  if sub-drawables != none and sub-drawables != () {

src/lib/axes.typ

@@ -460,7 +460,7 @@
 // - right (axis): Right axis
 // - top (axis): Top axis
 // - name (string): Object name
-// - draw-unset (bool): Draw unset axes
+// - draw-unset (bool): Draw axes that are set to `none`
 // - ..style (any): Style
 #let scientific(size: (1, 1),
  left: none,

tests/axes/test.typ

@@ -7,7 +7,7 @@
 
  set-style(axes: (
  stroke: blue,
- padding: .75,
+ padding: .25,
  x: (stroke: red),
  y: (stroke: green, tick: (stroke: blue, length: .3))
  ))
@@ -31,7 +31,7 @@
  angle: -45deg,
  anchor: "north-west"), length: -.1))))
  axes.scientific(size: (6, 6),
- frame: auto,
+ draw-unset: false,
  top: none,
  bottom: axes.axis(min: -1, max: 1, ticks: (step: 1, minor-step: auto,
  grid: "both", unit: [ units])),

tests/group/none/test.typ

@@ -0,0 +1,9 @@
+#set page(width: auto, height: auto)
+#import "/src/lib.typ": *
+#import "/tests/helper.typ": *
+
+#test-case({
+ import draw: *
+
+ group({})
+})