plot: Contour Plots #243
Merged
plot: Contour Plots #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes-wolf
force-pushed
the
cetz-215-contour-plots
branch
3 times, most recently
from
1aab104
to
d34c5f6
Compare
johannes-wolf
force-pushed
the
cetz-215-contour-plots
branch
from
d34c5f6
to
61c9cbe
Compare
johannes-wolf
force-pushed
the
cetz-215-contour-plots
branch
from
61c9cbe
to
94e2676
Compare
fenjalien
requested changes
Oct 9, 2023
There was a problem hiding this comment.
The outputs/drawings look amazing as always. Unfortunately I'm struggling to follow how this all works but thats mostly to do with how github has decided to present the changes. The other part is the function documentation barely makes sense, if you want specifics it would be better to discuss it over discord. Also does the manual need updating?
johannes-wolf
force-pushed
the
cetz-215-contour-plots
branch
4 times, most recently
from
201d756
to
845bef4
Compare
Tests are now detected by looking for files named "test.typ", rather than using each directory under "$TEST_ROOT".
johannes-wolf
force-pushed
the
cetz-215-contour-plots
branch
5 times, most recently
from
15847aa
to
4998dda
Compare
johannes-wolf
force-pushed
the
cetz-215-contour-plots
branch
from
4998dda
to
a661c05
Compare
fenjalien
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #215.
This mainly adds contour plot support but also is a first step in organizing the plotting lib by moving functions out of plot.typ into plot/... sub-files. Depends on #245.
Also adds
add-hline(+ vline) support for drawing lines that span a whole axis.This also fixes filling of parametric functions.