Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix manual #261

Merged
merged 1 commit into from
Oct 20, 2023
Merged

doc: Fix manual #261

merged 1 commit into from
Oct 20, 2023

Conversation

johannes-wolf
Copy link
Member

@johannes-wolf johannes-wolf commented Oct 17, 2023

Fixes the compilation of manual.typ.

@johannes-wolf johannes-wolf changed the base branch from master to redesign-internals October 17, 2023 19:39
@@ -315,7 +313,7 @@ line(a, b, c, stroke: gray)
bezier-through(a, b, c, name: "b")

// Show calculated control points
line(a, "b.ctrl-1", "b.ctrl-2", c, stroke: gray)
line(a, "b.ctrl-0", "b.ctrl-1", c, stroke: gray)
Copy link
Member Author

@johannes-wolf johannes-wolf Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change intended @fenjalien (having the first ctrl at index 0)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// #import "vector.typ"
// #import "matrix.typ"
// #import "tree.typ"
#import "styles.typ"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to have these exposed under cetz.*.

@fenjalien
Copy link
Member

I would like to leave the manual/docs alone until we finish some more reworks as it seems a bit futile if we're just going to break things again...

@johannes-wolf
Copy link
Member Author

johannes-wolf commented Oct 18, 2023

I would like to leave the manual/docs alone until we finish some more reworks as it seems a bit futile if we're just going to break things again...

Making it compile gives the benefit that changes to it from follow-up PRs can be compiled.
I would actually like to merge this to have a state on 0.2.0 that at least compilables.

@fenjalien
Copy link
Member

@johannes-wolf this needs rebasing

@johannes-wolf
Copy link
Member Author

Rebased.

@fenjalien fenjalien merged commit 6e28213 into redesign-internals Oct 20, 2023
2 checks passed
@johannes-wolf johannes-wolf deleted the redesign-fix-manual branch October 21, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants