-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Fix manual #261
doc: Fix manual #261
Conversation
@@ -315,7 +313,7 @@ line(a, b, c, stroke: gray) | |||
bezier-through(a, b, c, name: "b") | |||
|
|||
// Show calculated control points | |||
line(a, "b.ctrl-1", "b.ctrl-2", c, stroke: gray) | |||
line(a, "b.ctrl-0", "b.ctrl-1", c, stroke: gray) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this change intended @fenjalien (having the first ctrl at index 0)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its because bezier
's ctrl anchors start at 0.
https://github.com/johannes-wolf/cetz/blob/master/src/draw.typ#L990-L992
// #import "vector.typ" | ||
// #import "matrix.typ" | ||
// #import "tree.typ" | ||
#import "styles.typ" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to have these exposed under cetz.*
.
I would like to leave the manual/docs alone until we finish some more reworks as it seems a bit futile if we're just going to break things again... |
Making it compile gives the benefit that changes to it from follow-up PRs can be compiled. |
fbba1d1
to
58924ab
Compare
@johannes-wolf this needs rebasing |
60f1b1e
to
6105027
Compare
Rebased. |
Fixes the compilation of manual.typ.