Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plot: Minor Fixes #268

Merged
merged 3 commits into from
Oct 25, 2023
Merged

plot: Minor Fixes #268

merged 3 commits into from
Oct 25, 2023

Conversation

johannes-wolf
Copy link
Member

Fixes:

  • Add note about scatter-plots to the documentation of plot.add
  • Fix hline/vline domain and clipping

@johannes-wolf johannes-wolf added the bug 🐛 Something isn't working label Oct 21, 2023
@johannes-wolf johannes-wolf changed the base branch from master to redesign-internals October 21, 2023 15:59
@fenjalien
Copy link
Member

Looks okay but I'm not sure why tests are failing?

@johannes-wolf
Copy link
Member Author

Rebased the PR.
That the tests succeed is actually a bug! The tests can not succeed, because some features from master are currently missing and the test images have not been updated.

@johannes-wolf johannes-wolf merged commit c4c2a52 into redesign-internals Oct 25, 2023
@johannes-wolf johannes-wolf deleted the plot-minor-fixes branch October 25, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fenjalien fenjalien Awaiting requested review from fenjalien

Assignees
No one assigned
Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannes-wolf @fenjalien