shapes: Arc through #273
Merged
shapes: Arc through #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 23, 2023
johannes-wolf
force-pushed
the
cetz-206-arc-through
branch
2 times, most recently
from
ec7e67b
to
4feddf4
Compare
|
Rebased. |
johannes-wolf
force-pushed
the
cetz-206-arc-through
branch
2 times, most recently
from
f44cba2
to
2cafd29
Compare
fenjalien
requested changes
Nov 22, 2023
There was a problem hiding this comment.
What happens when a b c are in a striaght line? I'm guessing a divide by 0 happens somewhere, but could we have the panic message more verbose that it was arc-through? A check might need to be added before calculate-circle-center-3pt.
Update the changelog too
| @@ -304,6 +304,52 @@ | |||
| },) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Add documentation but maybe wait until #320 is merged
There was a problem hiding this comment.
I have added documentation + explanation of the calculation.
johannes-wolf
force-pushed
the
cetz-206-arc-through
branch
2 times, most recently
from
82c074e
to
fa8a9db
Compare
Thanks to Matthew Brown for the implementation.
johannes-wolf
force-pushed
the
cetz-206-arc-through
branch
from
fa8a9db
to
54d6da9
Compare
johannes-wolf
force-pushed
the
cetz-206-arc-through
branch
from
5ecd6c9
to
f142f53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206. Thanks to @matthew-e-brown for the initial implementation!