plot.add-boxwhisker - A second take on box-whisker plots
#287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Last thing to do is handle passing style through the chart. I'm an absolute novice with styles so can I leave that to one of the other contributors? |
Yes, I can do this in a follow-up PR. |
johannes-wolf
approved these changes
Oct 26, 2023
Closed
johannes-wolf
merged commit 27daf02
into
cetz-package:redesign-internals
1 check failed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #265, I implemented a box and whisker chart following the style of other charts, rather than implementing it as a plot. I believe this was a mistake as it quickly became cumbersome adding more features.
Rather than implement a box and whisker chart all in one go, I've opted to make a pull request where drawing a single box and whisker is handled by a plot.