Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Test fixes #288

Merged
merged 3 commits into from
Oct 26, 2023
Merged

tests: Test fixes #288

merged 3 commits into from
Oct 26, 2023

Conversation

johannes-wolf
Copy link
Member

@johannes-wolf johannes-wolf commented Oct 25, 2023

  • Remove the local package test.
  • Update all reference images: This is actually not correct, but would make tests succeed on the 0.2.0 branch. Since some features of master are missing, the test images are not matching as of now.
  • The test-script did not always return an != 0 exit code on failure

@fenjalien
Copy link
Member

Are you sure you want to update all of the tests? Most of them fail because of marks not being placed properly and they are yet to be worked on. When they do get worked on these tests will be very useful in not making a regression. So could we leave the specifically mark tests alone but the rest (which may have marks but are not the main focus) can be updated?

@johannes-wolf
Copy link
Member Author

johannes-wolf commented Oct 25, 2023

Are you sure you want to update all of the tests? Most of them fail because of marks not being placed properly and they are yet to be worked on. When they do get worked on these tests will be very useful in not making a regression. So could we leave the specifically mark tests alone but the rest (which may have marks but are not the main focus) can be updated?

Then maybe update none of the tests, but only fix the test script. I dropped the commit with the images.

@johannes-wolf johannes-wolf merged commit 94af05b into redesign-internals Oct 26, 2023
0 of 2 checks passed
@johannes-wolf johannes-wolf deleted the test-fixes branch October 26, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants