Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix: Unroll matrix-vector product #307

Merged
merged 1 commit into from
Oct 30, 2023
Merged

matrix: Unroll matrix-vector product #307

merged 1 commit into from
Oct 30, 2023

Conversation

johannes-wolf
Copy link
Member

@johannes-wolf johannes-wolf commented Oct 30, 2023 •
edited
Loading

This change gives about -100 ms for a line plot with 1000 data points.
Since matrix-vector multiplication is done a lot, this specialization should be used.
We actually never use non 4x4 matrices, so we could think about not supporting other matrix sizes in general.

@johannes-wolf johannes-wolf added the enhancement ⬆️ New feature or request label Oct 30, 2023
fenjalien
fenjalien approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@fenjalien fenjalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, nice work. I would like to keep the general version just in case. If mul-vec isn't used anywhere else its all good.

@johannes-wolf johannes-wolf merged commit b737b98 into redesign-internals Oct 30, 2023
0 of 2 checks passed
@johannes-wolf johannes-wolf deleted the matrix-vector-product-perf branch October 30, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fenjalien fenjalien fenjalien approved these changes

Assignees
No one assigned
Labels
enhancement ⬆️ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannes-wolf @fenjalien