Add transform function + Improve rotate #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes-wolf
force-pushed
the
fix-rotation-matrix
branch
2 times, most recently
from
0a58e34
to
ab85599
Compare
johannes-wolf
changed the title
johannes-wolf
force-pushed
the
fix-rotation-matrix
branch
from
ab85599
to
464a8d5
Compare
johannes-wolf
force-pushed
the
fix-rotation-matrix
branch
from
464a8d5
to
96e8ca0
Compare
fenjalien
requested changes
Nov 11, 2023
|
@fenjalien Applied all your remarks :) |
johannes-wolf
force-pushed
the
fix-rotation-matrix
branch
from
0172a5e
to
0ed089a
Compare
fenjalien
reviewed
Nov 12, 2023
johannes-wolf
force-pushed
the
fix-rotation-matrix
branch
from
0ed089a
to
3462a04
Compare
|
Updated the ref-images (rotation is now CCW) and added the bad values to the error messages. |
fenjalien
approved these changes
Nov 19, 2023
johannes-wolf
force-pushed
the
fix-rotation-matrix
branch
from
92c9e73
to
7f6707f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transform(matrix)function for setting or resetting the transformation matrixrotateto take a single angle or a set of named arguments of one of the lists: x, y, z or yaw, pitch, roll to create a rotation matrix