draw: Do not transform content anchors #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenjalien
reviewed
Nov 12, 2023
johannes-wolf
force-pushed
the
content-no-transform
branch
from
eaa5341
to
bc1b10f
Compare
johannes-wolf
force-pushed
the
content-no-transform
branch
from
bc1b10f
to
7c1e42e
Compare
johannes-wolf
changed the title
johannes-wolf
force-pushed
the
content-no-transform
branch
from
8ce40ee
to
9e86bc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content must not get transformed.
The only anchor that gets transformed is the
centeranchor. All other anchors must be calculated relative to that one.Fixes #256.
Also fixes content bounding box calculation. Calculating the width/height from north-south and east-west is not enough. Instead, use the already calculated anchors at all four corners to calculate the rotated width/height.