Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Angle Library #330

Merged
merged 6 commits into from
Nov 12, 2023
Merged

Update Angle Library #330

merged 6 commits into from
Nov 12, 2023

Conversation

johannes-wolf
Copy link
Member

@johannes-wolf johannes-wolf commented Nov 12, 2023

Use non-internal API for drawing angles.

Fixes #327.

@johannes-wolf johannes-wolf added the enhancement ⬆️ New feature or request label Nov 12, 2023
@johannes-wolf johannes-wolf added this to the 0.2 milestone Nov 12, 2023
@fenjalien fenjalien linked an issue Nov 12, 2023 that may be closed by this pull request
Base automatically changed from update-test-ref-images-after-mark to 0.2.0 November 12, 2023 16:26
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label in the top left is missing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is on purpose. I think it makes no sense displaying a label for a 0 degree angle.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

… but I re-added it.

@johannes-wolf johannes-wolf merged commit d4758b0 into 0.2.0 Nov 12, 2023
2 checks passed
@johannes-wolf johannes-wolf deleted the angle-lib-update branch November 12, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ⬆️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

angle: Make angle use the non-internal API
2 participants