plot: Plot Annotations #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes-wolf
force-pushed
the
plot-annotations
branch
3 times, most recently
from
95ab379
to
6f8cab9
Compare
fenjalien
reviewed
Nov 22, 2023
Comment on lines
+19
to
+34
| /// - resize (bool): If true, the plots axes get adjusted to contain the annotation | ||
| /// - padding (none,number,dictionary): Annotation padding that is used for axis | ||
| /// adjustment | ||
| /// - background (bool): If true, the annotation is drawn behind all plots, in the background. | ||
| /// If false, the annotation is drawn above all plots. |
There was a problem hiding this comment.
Could these be put into a style?
There was a problem hiding this comment.
Does not really make sense imho., as all three depend on the plot/data and are in plot units (padding).
johannes-wolf
force-pushed
the
plot-annotations
branch
4 times, most recently
from
cfb1839
to
a8b8255
Compare
johannes-wolf
changed the base branch from
0.2.0
to
readd-function-documentation
johannes-wolf
force-pushed
the
plot-annotations
branch
from
a8b8255
to
91709eb
Compare
johannes-wolf
force-pushed
the
plot-annotations
branch
from
91709eb
to
45b1a87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements cetz-package/cetz-plot#4 partly (in plot coordinates).
This PR adds
add-annotationto allow drawing in plots. The plot also gets resized to the drawing if it exceeds the axis bounds.In addition, it fixes
place-anchors, which raised an error because elements are not dictionaries anymore.