arc: Set previous point to arc end #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
|
Yes this makes sense so then the previous coordinate can be used to form a path more easily. Lets have it on by default and give a style option to turn it off |
johannes-wolf
force-pushed
the
fix-arc-prev-pt
branch
2 times, most recently
from
1792a02
to
c493875
Compare
fenjalien
approved these changes
Dec 4, 2023
johannes-wolf
force-pushed
the
fix-arc-prev-pt
branch
from
c493875
to
3631d40
Compare
johannes-wolf
force-pushed
the
fix-arc-prev-pt
branch
from
3631d40
to
b2cffa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
arccommand should update the previous point to its end-point.This might be inconsistent, though, as there are no other commands setting the previous point to a non user-provided one. Should we add an option to enable/disable this @fenjalien?