path: Normalize paths #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fenjalien
requested changes
Jan 18, 2024
|
Oh and how could we go about adding a test for this? Or would it be covered by a merge path test? |
Fixed. I've added a test case to the |
johannes-wolf
force-pushed
the
path-normalize
branch
from
269500d
to
2316e18
Compare
johannes-wolf
force-pushed
the
path-normalize
branch
from
2316e18
to
acd9f53
Compare
fenjalien
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, non-connecting paths are drawn but can give wrong intersections results. Even tiny gaps due to rounding errors can lead intersections to fail. This function tries to clean up paths by merging multiple ("line", ..) segments and adding missing ones.