Rework style (again) #377
Merged
Rework style (again) #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fenjalien
commented
Dec 5, 2023
fenjalien
commented
- Reworks styling to work in a kind of simpler way.
- Fixes wrong styling in an example in the manual
- Added detailed description of how styling works
johannes-wolf
requested changes
Dec 6, 2023
| @@ -665,17 +666,21 @@ | |||
| (calc.max(from.at(0), to.at(0)), calc.max(from.at(1), to.at(1))) | |||
| ) | |||
|
|
|||
| let style = styles.resolve(ctx.style, style) | |||
| if help-lines { | |||
| let style = styles.resolve(ctx.style, merge: style, root: "grid", base: ( | |||
There was a problem hiding this comment.
Any reason not having this in the default style dictionary?
There was a problem hiding this comment.
It doesn't really matter where the default of an element's style is. Really styles.default can just have stroke, fill, radius, padding, shorten and mark keys in it. Then use base for each element and it'll work just the same...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.