clipping: Add path clipping support #535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes-wolf
added
enhancement ⬆️
johannes-wolf
force-pushed
the
clipping
branch
7 times, most recently
from
6f64ad5 to
61dd7ee
Compare
fenjalien
reviewed
Mar 22, 2024
There was a problem hiding this comment.
Okay I've come around to the idea of keeping plugins in this repository. This is mostly due to the fact that I can't think of any alternatives that would cause more hassle and problems than they're worth.
I would like to propose a slight restructuring though. Put the plugin in a dedicated folder plugins/clipping/ and call it clipping.wasm instead of cetz.wasm.
The draw and lib folders probably need a restructure as well but that can be left to another PR.
|
We can not use contourklip because of it being GPL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements boolean path operations. The implementation is handled by a C++ library: contourklip.