chart: Piechart legend #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenjalien
approved these changes
May 2, 2024
johannes-wolf
force-pushed
the
piechart-legend
branch
from
1001965 to
a2bc2b9
Compare
johannes-wolf
force-pushed
the
piechart-legend
branch
4 times, most recently
from
73d05f2 to
f0943b5
Compare
johannes-wolf
force-pushed
the
piechart-legend
branch
from
f0943b5 to
30574ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #544.
This PR is a first step in improving the legend implementation by decoupling it from plot internals and thus allowing use outsides the plot API. Positioning is very basic as of now, as you can only use anchors of the chart to position the legend relative to.
There are still some improvements to do (in another PR), like improving the placement by migrating away from creating all the legend specific anchors.