Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort the list of roles when they're presented for selection #198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RonRothman
Copy link

@RonRothman RonRothman commented Sep 14, 2020

The main benefit is that lexicographically similar roles (e.g. same AWS account) will be adjacent, reducing errors. For example, what is currently presented this way:

[  1] arn:aws:iam::13856293331:role/admin
[  2] arn:aws:iam::20922837461:role/admin
[  3] arn:aws:iam::13856293331:role/eng/dev

would be presented this way:

[  2] arn:aws:iam::20922837461:role/admin
[  1] arn:aws:iam::13856293331:role/admin
[  3] arn:aws:iam::13856293331:role/eng/dev

The main benefit is that similar roles (e.g. same AWS account) will be adjacent.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.536% when pulling cbc96d7 on RonRothman:sort_roles_prompt into d473d67 on cevoaustralia:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants