Add support for one-time security codes #226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change even allows the docker image users to verify using they Yubikey since the verification is done on the browser. |
|
Test logs aren't available anymore but it's passing on clean venvs of Python 3.9, 3.8, and 3.7 on OSX. @stevemac007 is there anything this needs? Would really like to get it implemented. |
|
any update on this? might have to rip out and go with AWS SSO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for one-time security codes based on https://github.com/andreaso/aws-google-auth/tree/wip/skotp-support, and (at least partially) solves #202.
Tested locally, with a Google account configured with security keys. Tests included logins when other 2FA methods were also configured on the account.