-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #218 Switch base Docker image to python:3.6-alpine #239
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider updating the base image to python:3.9.12-alpine3.15
Dockerfile
Outdated
@@ -1,4 +1,4 @@ | |||
FROM alpine:3.5 | |||
FROM python:3.6-alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python:3.6-alphine
image is vulnerable to attacks. Can you consider updating to python:3.9.12-alpine3.15
and testing it?
68b39ae
to
9c71c19
Compare
Rebased my branch on master, updated to suggested image, tested locally. Seems to work fine. I did note a new Python timezone warning which I don't recall seeing previously:
It seems correct to default to UTC, but it seems a shame to get rid of the |
NB: I've pushed this branch as an image to |
hey @danmoz I've made a couple of minor updates on https://github.com/cevoaustralia/aws-google-auth/tree/feature/update-to-alpine-3.15 which brings us up to 3.15 for the Docker image; I've pushed it to https://hub.docker.com/layers/aws-google-auth/cevoaustralia/aws-google-auth/0.0.38-test/images/sha256-76d56b96c7a073b65836da5fdb628da408c7e3238aeaaa04976e2a323161fa94?context=explore and also adjusted the Dockerfile somewhat to reduce the size of the image (now 58MB compressed); however, I don't have a config to validate it. If you could give it a whirl and let us know if it works for you, I'll merge in the updates and promote the image to latest. |
Yep works fine, and the container is tiny! But it raises the
It would be nice to suppress this, would you consider adding |
To pile on, I had success with this on |
Upgrades the version of python, switching to the official Python Alpine base image (version 3.6). This resolves the following warning at startup:
PythonDeprecationWarning: Boto3 will no longer support Python 3.5 starting February 1, 2021. To continue receiving service updates, bug fixes, and security updates please upgrade to Python 3.6 or later. More information can be found here: https://aws.amazon.com/blogs/developer/announcing-the-end-of-support-for-python-3-4-and-3-5-in-the-aws-sdk-for-python-and-aws-cli-v1/