Support SAML assertion caching for multiple profiles #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the SAML assertion cache only works for a single profile. This is because the logic only caters for a single cache file. This PR allows response caching for multiple profiles, e.g.: ``` $ aws-google-auth --profile profile-a --keyring Please visit the following URL to view your CAPTCHA: https://... Captcha (case insensitive): ... MFA token: ... Assuming arn:aws:iam::111111111111:role/my-role Credentials Expiration: 2022-03-29 22:43:51+11:00 $ aws-google-auth --profile profile-b --keyring Please visit the following URL to view your CAPTCHA: https://... Captcha (case insensitive): ... MFA token: ... Assuming arn:aws:iam::222222222222:role/my-role Credentials Expiration: 2022-03-29 22:44:22+11:00 $ aws-google-auth --profile profile-a --keyring Assuming arn:aws:iam::111111111111:role/my-role Credentials Expiration: 2022-03-29 22:44:25+11:00 $ aws-google-auth --profile profile-b --keyring Assuming arn:aws:iam::222222222222:role/my-role Credentials Expiration: 2022-03-29 22:45:32+11:00 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the SAML assertion cache only works for a single profile. This
is because the logic only caters for a single cache file.
This PR allows response caching for multiple profiles, e.g.: