Skip to content

Commit

Permalink
test: re-enable localize warning check
Browse files Browse the repository at this point in the history
It can be re-enabled now that angular/angular#56300 have been released in v18.1.0-next.2
  • Loading branch information
cexbrayat committed Jul 1, 2024
1 parent f16fbd8 commit 69c6b4b
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions tests/legacy-cli/e2e/tests/i18n/extract-ivy.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { join } from 'path';
import { getGlobalVariable } from '../../utils/env';
import { expectFileToMatch, writeFile } from '../../utils/fs';
import { installPackage, uninstallPackage } from '../../utils/packages';
import { uninstallPackage } from '../../utils/packages';
import { ng } from '../../utils/process';
import { expectToFail } from '../../utils/utils';
import { readNgVersion } from '../../utils/version';
Expand Down Expand Up @@ -38,13 +38,12 @@ export default async function () {
if (getGlobalVariable('argv')['ng-snapshots']) {
localizeVersion = require('../../ng-snapshot/package.json').dependencies['@angular/localize'];
}
await installPackage(localizeVersion);
await ng('add', `@angular/localize@${localizeVersion}`, '--skip-confirmation');

// Should not show any warnings when extracting
const { stderr: message5 } = await ng('extract-i18n');
if (message5.includes('WARNING')) {
// TODO: enable once https://github.com/angular/angular/pull/56300 is released.
// throw new Error('Expected no warnings to be shown. STDERR:\n' + message5);
throw new Error('Expected no warnings to be shown. STDERR:\n' + message5);
}

await expectFileToMatch('messages.xlf', 'Hello world');
Expand Down

0 comments on commit 69c6b4b

Please sign in to comment.