Edge is msedge.exe, not edge.exe #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Nov 7, 2023
Summary: Andrew Coates graciously published the Windows Edge launcher fix from cezaraugusto/chromium-edge-launcher#1 as a new package (microsoft/rnx-kit#2796), so let's pull that into `dev-middleware`. Changelog: [Internal] - Fix experimental debugger launch flow with Edge on Windows Differential Revision: D51086297
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Nov 7, 2023
…41367) Summary: Andrew Coates graciously published the Windows Edge launcher fix from cezaraugusto/chromium-edge-launcher#1 as a new package (microsoft/rnx-kit#2796), so let's pull that into `dev-middleware`. Changelog: [Internal] - Fix experimental debugger launch flow with Edge on Windows Differential Revision: D51086297
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Nov 14, 2023
…41367) Summary: Andrew Coates graciously published the Windows Edge launcher fix from cezaraugusto/chromium-edge-launcher#1 as a new package (microsoft/rnx-kit#2796), so let's pull that into `dev-middleware`. Changelog: [Internal] - Fix experimental debugger launch flow with Edge on Windows Reviewed By: robhogan Differential Revision: D51086297
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Nov 14, 2023
…41367) Summary: Andrew Coates graciously published the Windows Edge launcher fix from cezaraugusto/chromium-edge-launcher#1 as a new package (microsoft/rnx-kit#2796), so let's pull that into `dev-middleware`. Changelog: [Internal] - Fix experimental debugger launch flow with Edge on Windows Reviewed By: robhogan Differential Revision: D51086297
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Nov 14, 2023
…41367) Summary: Andrew Coates graciously published the Windows Edge launcher fix from cezaraugusto/chromium-edge-launcher#1 as a new package (microsoft/rnx-kit#2796), so let's pull that into `dev-middleware`. Changelog: [Internal] - Fix experimental debugger launch flow with Edge on Windows Reviewed By: robhogan Differential Revision: D51086297
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Nov 15, 2023
…41367) Summary: Andrew Coates graciously published the Windows Edge launcher fix from cezaraugusto/chromium-edge-launcher#1 as a new package (microsoft/rnx-kit#2796), so let's pull that into `dev-middleware`. Changelog: [Internal] - Fix experimental debugger launch flow with Edge on Windows Reviewed By: robhogan Differential Revision: D51086297
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Nov 15, 2023
…41367) Summary: Andrew Coates graciously published the Windows Edge launcher fix from cezaraugusto/chromium-edge-launcher#1 as a new package (microsoft/rnx-kit#2796), so let's pull that into `dev-middleware`. Changelog: [Internal] - Fix experimental debugger launch flow with Edge on Windows Reviewed By: robhogan Differential Revision: D51086297
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 15, 2023
Summary: Pull Request resolved: #41367 Andrew Coates graciously published the Windows Edge launcher fix from cezaraugusto/chromium-edge-launcher#1 as a new package (microsoft/rnx-kit#2796), so let's pull that into `dev-middleware`. Changelog: [Internal] - Fix experimental debugger launch flow with Edge on Windows Reviewed By: robhogan Differential Revision: D51086297 fbshipit-source-id: 3a8db351f71eb31a9609c987cdb4dc66f24f9403
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…41367) Summary: Pull Request resolved: facebook#41367 Andrew Coates graciously published the Windows Edge launcher fix from cezaraugusto/chromium-edge-launcher#1 as a new package (microsoft/rnx-kit#2796), so let's pull that into `dev-middleware`. Changelog: [Internal] - Fix experimental debugger launch flow with Edge on Windows Reviewed By: robhogan Differential Revision: D51086297 fbshipit-source-id: 3a8db351f71eb31a9609c987cdb4dc66f24f9403
cezaraugusto
approved these changes
Feb 24, 2024
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 18, 2024
…43524) Summary: The [Windows fix](cezaraugusto/chromium-edge-launcher#1) was merged and published. We no longer need to use the fork. ## Changelog: [INTERNAL] [FIXED] - Fix experimental debugger launch flow with Edge on Windows Pull Request resolved: #43524 Test Plan: n/a Reviewed By: robhogan Differential Revision: D55013623 Pulled By: motiz88 fbshipit-source-id: bff2aa2801dd0dcdd6975dca0a2ec2aa9864ff6f
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Mar 19, 2024
Summary: A resubmission of D55013623 (Pull Request resolved: facebook#43524) with a fix for the internal `.flowconfig` issue that got the initial diff reverted. --- The [Windows fix](cezaraugusto/chromium-edge-launcher#1) was merged and published. We no longer need to use the fork. ## Changelog: [INTERNAL] [FIXED] - Fix experimental debugger launch flow with Edge on Windows Differential Revision: D55087731
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 20, 2024
…43562) Summary: Pull Request resolved: #43562 A resubmission of D55013623 (Pull Request resolved: #43524) with a fix for the internal `.flowconfig` issue that got the initial diff reverted. --- The [Windows fix](cezaraugusto/chromium-edge-launcher#1) was merged and published. We no longer need to use the fork. ## Changelog: [INTERNAL] [FIXED] - Fix experimental debugger launch flow with Edge on Windows Reviewed By: NickGerleman Differential Revision: D55087731 fbshipit-source-id: 6fd28a32447ad07dacdf6cd77390e18489fd6cfb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chromium-edge-launcher fails to find installed Edge on a windows machine due to it looking for the incorrect executable filename.