-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CF-checker warnings when following example H.11 (Atmospheric sounding profiles) #211
Comments
Not entirely sure what's happened here as there appears to be no section 9 in the conformance document to cover checking of discrete geometries although the checker does implement checks. I am happy to take an action to sort this out. |
Specific to the warnings above as far as I can see the current recommendation is that all variables except boundary, climatology and grid mapping variables specify a long_name or standard_name. So I think that warning is correct. Warnings are just there to flag recommendations, they don't mean that the file fails CF compliance. |
Chapter 9.5 of the CF Conventions document states:
It does not explicitly state that the variable should have no However, the variable with attribute
Thus, it should be explicitly stated in chapter 9.5 of the CF conventions document that @RosalynHatcher Is explicitly mentioned that the grid mapping variable does not have a Should I submit a new issue on this topic? |
Dear all Daniel @neumannd's comment reveals some inconsistency in the CF standard and conformance document. Section 3 of the conformance document has the recommendation, which he quoted,
but that recommendation isn't made in the preamble to Section 3 of the conventions, which says only that CF supports
Unfortunately this text doesn't say what kinds of variable the statement applies to! To clarify this, I suggest that
This is consistent with Appendix A. The Those statements also answer @neumannd's question about the grid mapping variable. That kind of variable does not have these attributes, according to Appendix A. Hence the checker would not give a warning if they are absent. Section 9.5, about coordinates and metadata for discrete sampling geometries, says "one of the coordinate or auxiliary coordinate variables of a discrete sampling geometry should have an attribute named In summary, I don't think there's a problem with the warnings that @GeyerB reported. The checker is correct. But there are some defects in the documents, as outlined above. Therefore I am going to close this issue now, since it was raised as a question and nothing has been said for over four years, with thanks to the contributors, and I will open a new defect ticket. Please reopen this issue or begin a new one if you think the question hasn't been answered. Jonathan |
In the example H.11 (version 1.7) the variable profile is given with
which is fine with me, but the checker produces warnings - could this be changed in next checker versions to INFO?
The text was updated successfully, but these errors were encountered: