Clarification that text-valued variables and attributes can be Unicode strings or UTF-8 char arrays
#556
Conversation
|
See my comment in #141 I understand why you think it's not necessary to specify the endowing for var-len strings, but I don't see why you think it's. a bad idea to do so. The rules are not any different for strings and char arrays, why make the language look like they are? |
| The other strings, such as "May", should be padded with trailing NULL or space characters so that every array element is filled. | ||
| If the atomic string option is chosen, each element of the variable can be assigned a string with a different length. | ||
| A text string can be stored either in a variable-length **`string`** or in a fixed-length **`char`** array. | ||
| In both cases, text strings must be represented in Unicode Normalization Form C (NFC, link:$$https://www.unicode.org/versions/Unicode16.0.0/UnicodeStandard-16.0.pdf$$[section 3.11] and link:$$https://unicode.org/reports/tr15$$[Annex 15] of the Unicode standard) and encoded according to UTF-8. |
There was a problem hiding this comment.
Do we need both links? though I suppose more is better.
Looks good!
There was a problem hiding this comment.
More is better, I think! I liked the annex because of its explanations, but the main text gives context.
history.adoc
Outdated
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| === Working version (most recent first) | |||
|
|
|||
| * {issues}141[Issue #141]: Clarification that text-valued variables and attributes can be Unicode vlen strings or UTF-8 char arrays. | |||
There was a problem hiding this comment.
Maybe:
Clarification that text-valued variables and attributes can be vlen strings or char arrays, encoded at UTF-8.
though this is the history, so precision isn't critical.
There was a problem hiding this comment.
Looks great, thanks for all the work!
There was a problem hiding this comment.
Changed to "Clarification that text may be stored in variables and attributes as either vlen strings or char arrays, and must be represented in Unicode Normalization Form C and encoded according to UTF-8."
|
Whoo Hoo! thanks all for getting this through! |
See issue #141 for discussion of these changes.
Release checklist
cf-conventions.adoc? Add in two places: on line 3 and under.Additional AuthorsinAbout the authors.history.adocup to date?