Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aisuite support #29

Conversation

davidberenstein1957
Copy link
Collaborator

@davidberenstein1957 davidberenstein1957 commented Nov 26, 2024

  • support for aisuite
  • basic integration tests based on examples/observers execution. We can consider extending this to stores but this would require a bit more mocking efforts.
  • code cleaning

@davidberenstein1957 davidberenstein1957 linked an issue Nov 26, 2024 that may be closed by this pull request
README.md Outdated Show resolved Hide resolved
@cfahlgren1
Copy link
Owner

Pushed a tiny commit to fix comment for an example

Co-authored-by: Caleb Fahlgren <cfahlgren1@gmail.com>
Copy link
Owner

@cfahlgren1 cfahlgren1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Looks good.

image

@cfahlgren1
Copy link
Owner

I wonder since aisuite implements openai if we don't necessarily need this and_ can just show an example with

wrap_openai on aisuite client?

unless you think the alias is useful?

@davidberenstein1957
Copy link
Collaborator Author

@cfahlgren1 I assume it still routes the logic to other LLM providers and does some of the mappings to the OpenAI schema for us, so I would say it is nice to add. Similarly to litellm also, just to have the coverage in case people are already using either one of the frameworks.

@davidberenstein1957 davidberenstein1957 merged commit 8be081e into main Nov 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] add support for aisuite and dozens of other providers
2 participants