Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify comparison of project definitions #1158

Open
3 tasks
donkirkby opened this issue Oct 17, 2024 · 0 comments
Open
3 tasks

Simplify comparison of project definitions #1158

donkirkby opened this issue Oct 17, 2024 · 0 comments

Comments

@donkirkby
Copy link
Member

donkirkby commented Oct 17, 2024

In step 4 of the release instructions in CONTRIBUTING.md, it says to download the project definitions from QAI, and compare them with the source code in projects.json and project_scoring.json. However, it looks like some recent changes have made that comparison harder.

  • The entries in the current files don't seem to be sorted, and the downloaded version is sorted. Add an option to just sort the current files without downloading them, just to help with comparisons.
  • The genotype_references key isn't downloaded, and might not be in the database at all. Either document that it can be ignored, or figure out where to download it from.
  • It looks like the extra references for the HIVGHA project (HIV1-CRF02_AG-GH-AB286855-seed and HIV1-CRF06_CPX-GH-AB286851-seed) are included in more places than they should be. Is that a bug in the download script?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant