Samples are not being uploaded as external datasets

[donkirkby]

The configuration looks right, so I'm not sure what the problem is.

• Make new samples upload as external datasets.
• Convert existing samples to external datasets. Split to issue Convert uploaded datasets to external ones Kive#745.
• Log a warning at startup if configuration doesn't work for external datasets.

[donkirkby]

The problem is this comparison:

            if (directory_path == self.config.raw_data or
                    directory_path in self.config.raw_data.parents):

In the current configuration, directory_path is /media/RAW_DATA/MiSeq/runs and self.config.raw_data is /media/RAW_DATA. The previous version added MiSeq/runs to self.config.raw_data before doing the comparison.

Options are:

• Add a second external file directory at /media/RAW_DATA to make the comparison work. That has the advantage of only being a configuration change.
• Change the comparison back, and wait for the next release before converting all the uploaded datasets to external datasets.