Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENT-11440: Added nghttp2 as a vendored dependency we build as part of the hub package for apache http2 support #1489

Closed
wants to merge 11 commits into from
Closed

ENT-11440: Added nghttp2 as a vendored dependency we build as part of the hub package for apache http2 support #1489

wants to merge 11 commits into from

Conversation

craigcomstock
Copy link
Contributor

@craigcomstock craigcomstock commented Aug 9, 2024 •
edited
Loading

Ticket: ENT-11440
Changelog: title

together:
cfengine/masterfiles#2944
#1489
cfengine/core#5610

@cf-bottom
Copy link

Thank you for submitting a PR! Maybe @larsewi can review this?

@craigcomstock craigcomstock marked this pull request as draft August 12, 2024 16:13
@craigcomstock
Copy link
Contributor Author

little typo in spec file, version -> nghttp2_version :p Build Status

@craigcomstock
Copy link
Contributor Author

Good deal, failure gives me the information I need to exclude files in the RPM spec file:

00:00:58 Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/jenkins/workspace/testing-pr/label/PACKAGES_HUB_x86_64_linux_redhat_7/nghttp2/BUILDROOT/cfbuild-nghttp2-0+215d80d+untested-1.x86_64
00:00:58 error: Installed (but unpackaged) file(s) found:
00:00:58    /var/cfengine/lib/libnghttp2.a
00:00:58    /var/cfengine/lib/libnghttp2.la
00:00:58    /var/cfengine/share/doc/nghttp2/README.rst
00:00:58    /var/cfengine/share/man/man1/h2load.1
00:00:58    /var/cfengine/share/man/man1/nghttp.1
00:00:58    /var/cfengine/share/man/man1/nghttpd.1
00:00:58    /var/cfengine/share/man/man1/nghttpx.1
00:00:58    /var/cfengine/share/nghttp2/fetch-ocsp-response
00:00:58 
00:00:58 
00:00:58 RPM build errors:
00:00:58     Installed (but unpackaged) file(s) found:
00:00:58    /var/cfengine/lib/libnghttp2.a
00:00:58    /var/cfengine/lib/libnghttp2.la
00:00:58    /var/cfengine/share/doc/nghttp2/README.rst
00:00:58    /var/cfengine/share/man/man1/h2load.1
00:00:58    /var/cfengine/share/man/man1/nghttp.1
00:00:58    /var/cfengine/share/man/man1/nghttpd.1
00:00:58    /var/cfengine/share/man/man1/nghttpx.1
00:00:58    /var/cfengine/share/nghttp2/fetch-ocsp-response
00:00:58 + status=failure

@craigcomstock
Copy link
Contributor Author

try a build for rhel7hub and ubu20hub Build Status

@craigcomstock
Copy link
Contributor Author

fixed rpm maybe Build Status (rhel7hub only)

@craigcomstock
Added nghttp2 as a vendored dependency we build as part of the hub pa…
9e6acde 
…ckage for apache http2 support

In order to use http2 module we must switch from mpm prefork in apache to fpm in php

Ticket: ENT-11440
Changelog: title
@craigcomstock
Copy link
Contributor Author

craigcomstock commented Aug 13, 2024 •
edited
Loading

ok, I guess --enable-fpm also enables ZTS (zend thread safety) so the name of the extensions folder has changed from no-debug-non-zts- to no-debug-zts-

Build Status

@craigcomstock
Copy link
Contributor Author

another try, needed to add some new files in php package for fpm Build Status

@craigcomstock
Copy link
Contributor Author

Try with fpm configuration setup properly. One thing left: php-fpm as a service

Build Status

@craigcomstock
Copy link
Contributor Author

Build Status

@craigcomstock
Copy link
Contributor Author

Build Status

@craigcomstock
Copy link
Contributor Author

Build Status

@craigcomstock craigcomstock mentioned this pull request Aug 16, 2024
Draft
@craigcomstock
Copy link
Contributor Author

with masterfiles Build Status

@aleksandrychev
Copy link
Contributor

aleksandrychev commented Aug 23, 2024 •
edited
Loading

@craigcomstock please add https://github.com/cfengine/mission-portal/pull/2595 https://github.com/cfengine/nova/pull/2325 to the together section

@aleksandrychev
Copy link
Contributor

with master/mp/nova Build Status

@craigcomstock @aleksandrychev
Update deps-packaging/php/www.conf
74de7e9 
Co-authored-by: Igor Aleksandrychev <16775360+aleksandrychev@users.noreply.github.com>
@craigcomstock
Copy link
Contributor Author

get a rhel7hub package to see where we are at: Build Status

@craigcomstock
Copy link
Contributor Author

craigcomstock commented Sep 12, 2024 •
edited
Loading

moving on to another PR... #1495

@craigcomstock craigcomstock mentioned this pull request Sep 12, 2024
Draft
@craigcomstock craigcomstock deleted the ENT-11440/master branch October 7, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandrychev aleksandrychev aleksandrychev left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@craigcomstock @cf-bottom @aleksandrychev