Added back validation of modules in "build" if present #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
olehermanse
commented
Jan 9, 2024
olehermanse
commented
- Renamed parameter require_build_actions
- Added back validation of modules in "build" if present
No change in behavior here, just thought it would be a little more explicit / clear / maintainable to flip the logic and change the name. The _only_ thing this variable should do is say that if the "build" key contains an empty list, that's okay. Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
If they are there we should validate them, regardless of whether they are required to be there. Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
larsewi
approved these changes
Jan 9, 2024
…alidate Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
olehermanse
force-pushed
the
validation
branch
from
0bd2698
to
c16d6e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.