ENT-11811: cfbs recognizes and commits module input changes #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsewi
reviewed
May 27, 2024
larsewi
approved these changes
May 27, 2024
cfbs/git.py
Outdated
| @@ -189,7 +197,7 @@ def git_check_tracked_changes(scope=["all"]): | |||
| else: | |||
| lines = result.stdout.decode("utf-8").split("\n") | |||
| changes = [line.strip().split(" ")[1] for line in lines if line] | |||
| should_commit = any(i in changes for i in scope) | |||
| should_commit = _get_should_commit(changes, scope) | |||
There was a problem hiding this comment.
You can use itertools.product() it test all the files against each other
>>> from itertools import product
>>> list(product(["1", "2", "3"], ["A", "B", "C"]))
[('1', 'A'), ('1', 'B'), ('1', 'C'), ('2', 'A'), ('2', 'B'), ('2', 'C'), ('3', 'A'), ('3', 'B'), ('3', 'C')]E.g.,
should_commit = any(os.path.samefile(a, b) in itertools.product(changes, scope))But what you did also OK ;)
Ticket: ENT-11811 Changelog: None Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: ENT-11811
Changelog: None
Signed-off-by: Mikita Pilinka mikita.pilinka@northern.tech