Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENT-9556: cfbs status now displays module versions in addition to commit hashes #197

Merged
merged 3 commits into from
Jul 24, 2024
Merged

ENT-9556: cfbs status now displays module versions in addition to commit hashes #197

merged 3 commits into from
Jul 24, 2024

Conversation

jakub-nt
Copy link
Contributor

@jakub-nt jakub-nt commented Jul 22, 2024 •
edited
Loading

Before:

$ cfbs status
Name:        Example project
Description: Example description
File:        cfbs.json

Modules:
001 masterfiles               @ 691c6b2d11eefcfcda2e2b0d1de33440cec112a9 (Downloaded)
002 autorun                   @ c3b7329b240cf7ad062a0a64ee8b607af2cb912a (Not downloaded)
003 ./policy-module-template/ @ local                                    (Copied)

After:

$ cfbs status
Name:        Example project
Description: Example description
File:        cfbs.json

Modules:
001 masterfiles               @ 3.21.5 / 691c6b2d11eefcfcda2e2b0d1de33440cec112a9 (Downloaded)
002 autorun                   @ 1.0.1  / c3b7329b240cf7ad062a0a64ee8b607af2cb912a (Not downloaded)
003 ./policy-module-template/ @ local                                             (Copied)

@jakub-nt
Make the longest module name length function more generic
9d0ad4d 
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
@jakub-nt
Fix longest_module_key_length failing when the key did not exist
95c5f62 
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
@olehermanse olehermanse self-requested a review July 22, 2024 14:48
@jakub-nt jakub-nt changed the title ENT-9556: Display module versions in cfbs status in addition to commit hashes ENT-9556: cfbs status now displays module versions in addition to commit hashes Jul 22, 2024
@jakub-nt
cfbs status now displays module versions in addition to commit hashes
32b0850 
Changelog: Title

Ticket: ENT-9556
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
olehermanse
olehermanse approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks :)

@olehermanse olehermanse merged commit 968d4b0 into cfengine:master Jul 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olehermanse olehermanse olehermanse approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakub-nt @olehermanse