Add argument to specify minimal version in cfbs generate-release-information
#215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormation` Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
|
Thanks for submitting a pull request! Maybe @larsewi can review this? |
larsewi
reviewed
Dec 4, 2024
| @@ -120,3 +120,9 @@ def version_as_comparable_list_negated(version): | |||
| vcl[1] = [-x for x in vcl[1]] | |||
|
|
|||
| return vcl | |||
|
|
|||
|
|
|||
| def version_is_at_least(version, min_version): | |||
There was a problem hiding this comment.
It would be nice to have a couple of versions compare functions in utils.py for the different comparison operators > , < , >= , <= , == , and != along with unit tests. This is probably out of the scope of this PR. But feel free to do that in a follow-up PR, if you are up for the challenge 😉 I believe we compare versions in multiple places throughout this project. cfbs add is one example.
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
larsewi
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.